Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python(feat): Report templates service #145

Merged
merged 32 commits into from
Dec 3, 2024
Merged

Conversation

niliayu
Copy link
Collaborator

@niliayu niliayu commented Nov 26, 2024

This PR adds a ReportTemplateService that allows users to create, update, fetch, and archive report templates. There are also examples of how to define report templates in python, in yaml, and how to fetch, update, and archive those created templates. This also notably adds the ReportTemplateConfig as a pydantic model.

@niliayu niliayu marked this pull request as draft November 26, 2024 19:35
@niliayu niliayu marked this pull request as ready for review November 27, 2024 00:06
python/lib/sift_py/report_templates/service.py Outdated Show resolved Hide resolved
python/lib/sift_py/report_templates/service.py Outdated Show resolved Hide resolved
python/lib/sift_py/report_templates/config.py Outdated Show resolved Hide resolved
python/lib/sift_py/ingestion/config/yaml/spec.py Outdated Show resolved Hide resolved
python/lib/sift_py/ingestion/config/yaml/load.py Outdated Show resolved Hide resolved
@niliayu niliayu requested a review from solidiquis December 2, 2024 19:28
Copy link
Collaborator

@solidiquis solidiquis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@niliayu niliayu merged commit 8d1e22c into main Dec 3, 2024
7 checks passed
@niliayu niliayu deleted the python/report-templates branch December 3, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants